Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Derive Ord and PartialOrd for NoteTag" #654

Merged
merged 1 commit into from
May 2, 2024

Conversation

hackaugusto
Copy link
Contributor

@hackaugusto hackaugusto commented May 2, 2024

Reverts #644

The above PR included #642, #642 should not be included. Reverting the changes.

@hackaugusto hackaugusto requested review from bobbinth and polydez May 2, 2024 14:07
@hackaugusto
Copy link
Contributor Author

I don't have admin rights, I can't merge this without an approval.

Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, apologies for the mishap

@tomyrd
Copy link
Collaborator

tomyrd commented May 2, 2024

Yes sorry, it was my bad. I wasn't careful enough and didn't check the commit list before merging.

@hackaugusto hackaugusto merged commit 06e25d7 into next May 2, 2024
9 checks passed
@hackaugusto hackaugusto deleted the revert-644-tomyrd-add-ord-to-note-tag branch May 2, 2024 14:41
@hackaugusto
Copy link
Contributor Author

Yes sorry, it was my bad. I wasn't careful enough and didn't check the commit list before merging.

No worries :)

bobbinth pushed a commit that referenced this pull request May 13, 2024
bobbinth pushed a commit that referenced this pull request May 14, 2024
Fumuran pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants